Ribbon fuse pool by chudnov · Pull Request #1 · ribbon-finance/compound-protocol

chudnov · 2022-04-01T21:31:37Z

Tests can be found in governance repo pr. It includes same RibbonVaultAssetOracle.sol and simplified versions of CERC20.sol and RewardsDistributorDelegate.sol

chudnov · 2022-04-01T21:32:52Z

+import "./interfaces/ILiquidityGauge.sol";
+import "./interfaces/IRibbonVault.sol";
+import {DSMath} from "./libraries/DSMath.sol";
+


tests for this

chudnov · 2022-04-05T22:46:30Z

+     * @param cToken The market whose COMP speed to update
+     */
+    function _updateSpeedWithNewEpoch(CToken cToken) public {
+        require(block.timestamp.sub(startTime) >= WEEK, "Must be at least week since latest epoch");


potential issues:

1: if _updateSpeedWithNewEpoch not called from cron job w fast enough cadence it could be spreading rewards for longer duration than the speed duration was set for (longer than a week). But should not be a problem as long as we continue minting each week so even if we call late they can claim from balance of subsequent (essentially kick can down road indefinitely)

2: if AVG_BLOCKS_PER_WEEK is off, we could be giving out more rewards than speed duration set for (ex: we assume AVG is x but we end up having 1.0025x blocks so we spread out same rewards for more blocks. But should average out and again should not be a problem as long as we continue minting each week so even if we call late they can claim from balance of subsequent (essentially kick can down road indefinitely).

chudnov · 2022-04-05T22:47:33Z

+    /**
+     * @notice Set new borrow / supply speed
+     * @param cToken The market whose COMP speed to update
+     */


_updateSpeedWithNewEpoch needs to be called from cron job weekly

kenchangh · 2022-04-06T02:26:44Z

+    // Minter contract for rbn gauge emissions
+    RibbonMinter public constant RBN_MINTER = RibbonMinter(0x5B0655F938A72052c46d2e94D206ccB6FF625A3A);
+    // RBN token
+    IERC20Upgradeable public constant RBN = IERC20Upgradeable(0x6123b0049f904d730db3c36a31167d9d4121fa6b);


We can use IERC20 because we're not touching any of the upgradeable functionality

kenchangh · 2022-04-06T02:47:25Z

+        // Underlying is the gauge token like rETH-THETA-gauge
+        RBN_MINTER.mint(underlying)
+
+        uint256 toDistribute = RBN.balanceOf(address(this));


We can add these lines to return early

if (toDistribute == 0) { return; }

kenchangh · 2022-04-06T02:53:10Z

        bool distributorAdded = false;
        address[] memory distributors = comptroller.getRewardsDistributors();
-        for (uint256 i = 0; i < distributors.length; i++) if (distributors[i] == address(this)) distributorAdded = true; 
+        for (uint256 i = 0; i < distributors.length; i++) if (distributors[i] == address(this)) distributorAdded = true;


Gas optimization for loop:

uint256 distributorsLen = distributors.length; for (uint256 i = 0; i < distributorsLen; ++i)

is distributors.length really calculated multiple times? this code was not changed its from original comp

kenchangh · 2022-04-06T02:53:38Z

+     * @notice Set borrower PCT
+     */
+    function _setBorrowerPCT(uint256 _borrowerPCT) public {
+        require(msg.sender == admin, "only admin can set comp speed");


nit only admin can set borrower percent

kenchangh · 2022-04-06T03:07:14Z

+     * @notice Set new borrow / supply speed
+     * @param cToken The market whose COMP speed to update
+     */
+    function _updateSpeedWithNewEpoch(CToken cToken) public {


We can rename this to be without underscore since it's public updateSpeedWithNewEpoch. We can also change it to external

function updateSpeedWithNewEpoch(CToken cToken) external {

kenchangh · 2022-04-06T03:08:32Z

+     * @notice Burn
+     * @param Takes in RBN tokens
+     */
+    function burn(uint256 amount) public {


Can change this to external

sriyantra · 2022-04-10T21:19:58Z


+        uint256 toDistribute = RBN.balanceOf(address(this));
+
+        RBN.approve(rewardsDistributor, toDistribute)


you don't want to do an infinite approval once, like in becomeImplementationData?

kenchangh · 2022-04-11T11:16:17Z

+
+    IRibbonVault vault = IRibbonVault(ILiquidityGauge(underlying).lp_token());
+    uint256 rVaultDecimals = vault.decimals();
+    uint256 rVaultToAssetExchangeRate = vault.pricePerShare(); // (ex: rETH-THETA -> ETH, rBTC-THETA -> BTC)


Do we not have to lookup the Uniswap v3 pool for this price?

chudnov · 2022-04-16T23:03:42Z

@@ -1,18 +1,35 @@
 pragma solidity ^0.5.16;



tests for this

chudnov · 2022-04-16T23:03:51Z

+
    /// @dev Notice that this contract is a RewardsDistributor
    bool public constant isRewardsDistributor = true;



tests for this

add claim reward functionality

23922b7

chudnov changed the base branch from master to fuse-final April 1, 2022 21:31

chudnov commented Apr 1, 2022

View reviewed changes

Your Name added 2 commits April 1, 2022 14:39

upper

3c5bfe4

add epoch based reward

0b20ee0

chudnov commented Apr 5, 2022

View reviewed changes

kenchangh reviewed Apr 6, 2022

View reviewed changes

address comments

89fe5c3

sriyantra reviewed Apr 10, 2022

View reviewed changes

kenchangh reviewed Apr 11, 2022

View reviewed changes

Your Name added 7 commits April 16, 2022 14:31

change revert message

c1ed18e

remove bad require

05e9e12

keep

3cede01

swap borrower with supply speeds

cd396bc

allow borrow pct to be 0

99db425

add semicolon

89b6d6f

add semicolon

688aac2

chudnov commented Apr 16, 2022

View reviewed changes

Comment thread contracts/CErc20.sol

@@ -1,18 +1,35 @@

pragma solidity ^0.5.16;

chudnov Apr 16, 2022

Copy link
Copy Markdown

Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests for this

chudnov commented Apr 16, 2022

View reviewed changes

Your Name added 5 commits April 17, 2022 16:16

use older version of ierc20

4684929

fix undeclared identifier

b753fc8

fix undeclared identifier

3fe0665

fix compile errors, make avgBlocksPerWeek adjustable

f45c116

change error for _setAvgBlocksPerWeek

31b9857

Your Name added 2 commits April 17, 2022 16:50

change from undeclared identifier

a9926a6

fix last compile error

378a91f

kenchangh approved these changes Apr 18, 2022

View reviewed changes

Your Name added 6 commits April 17, 2022 22:25

differentiate totalMint

55b258b

supplier

5645f70

add events and recoverAsset

7f63e3d

change to _recoverAsset

3ddbab1

add reward stables

a0640a2

address audit

50beda2

chudnov changed the base branch from fuse-final to fuse-reactive-audit May 16, 2022 22:18

chudnov changed the base branch from fuse-reactive-audit to fuse-final May 16, 2022 22:18

chudnov changed the base branch from fuse-final to fuse-reactive-audit May 16, 2022 22:18

chudnov changed the base branch from fuse-reactive-audit to fuse-final May 16, 2022 22:19

chudnov changed the base branch from fuse-final to fuse-reactive-audit May 16, 2022 22:36

chudnov changed the base branch from fuse-reactive-audit to fuse-final May 16, 2022 22:43

mul with 10 ** 8

eedf42c


		uint256 toDistribute = RBN.balanceOf(address(this));

		RBN.approve(rewardsDistributor, toDistribute)


		/// @dev Notice that this contract is a RewardsDistributor
		bool public constant isRewardsDistributor = true;

Uh oh!

Conversation

chudnov commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chudnov Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kenchangh Apr 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chudnov commented Apr 1, 2022 •

edited

Loading

chudnov Apr 5, 2022 •

edited

Loading

kenchangh Apr 11, 2022 •

edited

Loading